DTSCCI-3856 High severity constant naming cleanup in DJ enums by matt-goodwin-solirius · Pull Request #7678 · hmcts/civil-service

matt-goodwin-solirius · 2026-03-31T09:15:45Z

Before creating a pull request make sure that:

commit messages are meaningful and follow good commit message guidelines
README and other documentation has been updated / added (if needed)
tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/DTSCCI-3856

Change description

High severity constant naming cleanup in DJ enums

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

hmcts-jenkins-a-to-c · 2026-04-01T11:34:27Z

Plan Result (aat)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 0 to change, 1 to destroy.

Delete
- module.key-vault.azurerm_key_vault_access_policy.jenkins[0]

Change Result (Click me)

  # data.azurerm_user_assigned_identity.app_mi will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "azurerm_user_assigned_identity" "app_mi" {
      + client_id           = (known after apply)
      + id                  = (known after apply)
      + isolation_scope     = (known after apply)
      + location            = (known after apply)
      + name                = "civil-aat-mi"
      + principal_id        = (known after apply)
      + resource_group_name = "managed-identities-aat-rg"
      + tags                = (known after apply)
      + tenant_id           = (known after apply)
    }

  # module.key-vault.azurerm_key_vault_access_policy.jenkins[0] will be destroyed
  # (because index [0] is out of range for count)
  - resource "azurerm_key_vault_access_policy" "jenkins" {
      - certificate_permissions = [
          - "Create",
          - "Delete",
          - "DeleteIssuers",
          - "Get",
          - "GetIssuers",
          - "Import",
          - "List",
          - "ListIssuers",
          - "SetIssuers",
          - "Update",
          - "ManageContacts",
          - "ManageIssuers",
        ] -> null
      - id                      = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/objectId/14b22215-46e6-48a9-8681-e8cefe66236a" -> null
      - key_permissions         = [
          - "Create",
          - "List",
          - "Get",
          - "Delete",
          - "Update",
          - "Import",
          - "Backup",
          - "Restore",
          - "Decrypt",
          - "Encrypt",
          - "UnwrapKey",
          - "WrapKey",
          - "Sign",
          - "Verify",
          - "GetRotationPolicy",
        ] -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat" -> null
      - object_id               = "14b22215-46e6-48a9-8681-e8cefe66236a" -> null
      - secret_permissions      = [
          - "Set",
          - "List",
          - "Get",
          - "Delete",
          - "Recover",
          - "Purge",
        ] -> null
      - storage_permissions     = [] -> null
      - tenant_id               = "531ff96d-0ae9-462a-8d2d-bec7c0b42082" -> null
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 0 to change, 1 to destroy.

hmcts-jenkins-a-to-c · 2026-04-01T11:35:08Z

Plan Result (prod)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 0 to change, 1 to destroy.

Delete
- module.key-vault.azurerm_key_vault_access_policy.jenkins[0]

Change Result (Click me)

  # data.azurerm_user_assigned_identity.app_mi will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "azurerm_user_assigned_identity" "app_mi" {
      + client_id           = (known after apply)
      + id                  = (known after apply)
      + isolation_scope     = (known after apply)
      + location            = (known after apply)
      + name                = "civil-prod-mi"
      + principal_id        = (known after apply)
      + resource_group_name = "managed-identities-prod-rg"
      + tags                = (known after apply)
      + tenant_id           = (known after apply)
    }

  # module.key-vault.azurerm_key_vault_access_policy.jenkins[0] will be destroyed
  # (because index [0] is out of range for count)
  - resource "azurerm_key_vault_access_policy" "jenkins" {
      - certificate_permissions = [
          - "Create",
          - "Delete",
          - "DeleteIssuers",
          - "Get",
          - "GetIssuers",
          - "Import",
          - "List",
          - "ListIssuers",
          - "SetIssuers",
          - "Update",
          - "ManageContacts",
          - "ManageIssuers",
        ] -> null
      - id                      = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/civil-service-prod/providers/Microsoft.KeyVault/vaults/civil-prod/objectId/c860eaa0-74be-4731-8370-db94c5fdad81" -> null
      - key_permissions         = [
          - "Create",
          - "List",
          - "Get",
          - "Delete",
          - "Update",
          - "Import",
          - "Backup",
          - "Restore",
          - "Decrypt",
          - "Encrypt",
          - "UnwrapKey",
          - "WrapKey",
          - "Sign",
          - "Verify",
          - "GetRotationPolicy",
        ] -> null
      - key_vault_id            = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/civil-service-prod/providers/Microsoft.KeyVault/vaults/civil-prod" -> null
      - object_id               = "c860eaa0-74be-4731-8370-db94c5fdad81" -> null
      - secret_permissions      = [
          - "Set",
          - "List",
          - "Get",
          - "Delete",
          - "Recover",
          - "Purge",
        ] -> null
      - storage_permissions     = [] -> null
      - tenant_id               = "531ff96d-0ae9-462a-8d2d-bec7c0b42082" -> null
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 0 to change, 1 to destroy.

github-actions · 2026-04-13T04:03:28Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Co-authored-by: douglasrice <douglasrice@yahoo.com>

* DTSCCI-3978: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * Update StandardDirectionOrderDJTest.java * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980/DTSCCI-4015: SDO Amendments * DTSCCI-3978/DTSCCI-3980/DTSCCI-4015: SDO Amendments * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3242: update mark paid in full process * DTSCCI-3978: SDO Amendments to be made in Credit Hire section * Dtscci-4307 fixed beforeRecordScenario() cleanup dropped from Evidenc… (#7681) * Dtscci-4307 Remove beforeRecordScenario() from TrialArrangementsNotifyOtherParty services to prevent blanket notification deletion and fix incorrect claimant notification * DTSCCI-4237-fix 5 workingday for ga non-urgent and withnotice scenario (#7703) * DTSCCI-4237-fix 5 workingday for ga non-urgent and withnotice scenario * Group lombok upgrades in its inividual renovate PR (#7742) * DTSCCI-3856 High severity constant naming cleanup in DJ enums (#7678) Co-authored-by: douglasrice <douglasrice@yahoo.com> * DTSCCI-4173 Refactor upload_translated_document_claimant_rejects_repayment_plan.bpmn to use generic notify event (#7633) Select the Welsh manual-determination email template for claimant LiPs with a bilingual language preference; fall back to the English template otherwise. Tests cover both bilingual and non-bilingual cases. * DTSCCI-4067 Include interest in the JBA order as part of the claim amount (#7690) * DTSCCI-4067 Include interest in the JBA order as part of the claim amount * DTSCCI-4067 changes * DTSCCI-4067 changes * DTSCCI-4067 changes --------- Co-authored-by: Raja Mani <rajakm@gmail.com> --------- Co-authored-by: Raja Mani <rajakm@gmail.com> Co-authored-by: rakeshchiluka14 <59172762+rakeshchiluka14@users.noreply.github.com> Co-authored-by: bharatkumarpatel1 <Bharatkumar.Patel1@HMCTS.NET> Co-authored-by: Sabah u Din Irfan <sabah.irfan@gmail.com> Co-authored-by: Matt Goodwin <matt.goodwin@solirius.com> Co-authored-by: douglasrice <douglasrice@yahoo.com> Co-authored-by: Anirudha <67697720+anirudha-deshpande@users.noreply.github.com> Co-authored-by: mounikahmcts <43175082+mounikahmcts@users.noreply.github.com>

* trial sdo changes * trial sdo changes * DTSCCI-3978: SDO Amendments to be made in Credit Hire section (#7606) * DTSCCI-3978: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * Update StandardDirectionOrderDJTest.java * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3978/DTSCCI-3980/DTSCCI-4015: SDO Amendments * DTSCCI-3978/DTSCCI-3980/DTSCCI-4015: SDO Amendments * DTSCCI-3978/DTSCCI-3980: SDO Amendments to be made in Credit Hire section * DTSCCI-3242: update mark paid in full process * DTSCCI-3978: SDO Amendments to be made in Credit Hire section * Dtscci-4307 fixed beforeRecordScenario() cleanup dropped from Evidenc… (#7681) * Dtscci-4307 Remove beforeRecordScenario() from TrialArrangementsNotifyOtherParty services to prevent blanket notification deletion and fix incorrect claimant notification * DTSCCI-4237-fix 5 workingday for ga non-urgent and withnotice scenario (#7703) * DTSCCI-4237-fix 5 workingday for ga non-urgent and withnotice scenario * Group lombok upgrades in its inividual renovate PR (#7742) * DTSCCI-3856 High severity constant naming cleanup in DJ enums (#7678) Co-authored-by: douglasrice <douglasrice@yahoo.com> * DTSCCI-4173 Refactor upload_translated_document_claimant_rejects_repayment_plan.bpmn to use generic notify event (#7633) Select the Welsh manual-determination email template for claimant LiPs with a bilingual language preference; fall back to the English template otherwise. Tests cover both bilingual and non-bilingual cases. * DTSCCI-4067 Include interest in the JBA order as part of the claim amount (#7690) * DTSCCI-4067 Include interest in the JBA order as part of the claim amount * DTSCCI-4067 changes * DTSCCI-4067 changes * DTSCCI-4067 changes --------- Co-authored-by: Raja Mani <rajakm@gmail.com> --------- Co-authored-by: Raja Mani <rajakm@gmail.com> Co-authored-by: rakeshchiluka14 <59172762+rakeshchiluka14@users.noreply.github.com> Co-authored-by: bharatkumarpatel1 <Bharatkumar.Patel1@HMCTS.NET> Co-authored-by: Sabah u Din Irfan <sabah.irfan@gmail.com> Co-authored-by: Matt Goodwin <matt.goodwin@solirius.com> Co-authored-by: douglasrice <douglasrice@yahoo.com> Co-authored-by: Anirudha <67697720+anirudha-deshpande@users.noreply.github.com> Co-authored-by: mounikahmcts <43175082+mounikahmcts@users.noreply.github.com> --------- Co-authored-by: mounikaammineni <mounilka.ammineni1@hmcts.net> Co-authored-by: rishikrsharma <rishikrsharma@users.noreply.github.com> Co-authored-by: Raja Mani <rajakm@gmail.com> Co-authored-by: rakeshchiluka14 <59172762+rakeshchiluka14@users.noreply.github.com> Co-authored-by: bharatkumarpatel1 <Bharatkumar.Patel1@HMCTS.NET> Co-authored-by: Sabah u Din Irfan <sabah.irfan@gmail.com> Co-authored-by: Matt Goodwin <matt.goodwin@solirius.com> Co-authored-by: douglasrice <douglasrice@yahoo.com> Co-authored-by: Anirudha <67697720+anirudha-deshpande@users.noreply.github.com>

DTSCCI-3856 High severity constant naming cleanup in DJ enums

226ee54

matt-goodwin-solirius requested a review from a team as a code owner March 31, 2026 09:15

hmcts-jenkins-a-to-c Bot deployed to preview March 31, 2026 09:27 View deployment

hmcts-jenkins-a-to-c Bot added ns:civil prd:civil rel:civil-service-pr-7678 labels Mar 31, 2026

gajanan-deshpande approved these changes Mar 31, 2026

View reviewed changes

douglasrice added enable_keep_helm pr-values:enableWA labels Apr 1, 2026

hmcts-jenkins-a-to-c Bot added the aat/destroy label Apr 1, 2026

hmcts-jenkins-a-to-c Bot added the prod/destroy label Apr 1, 2026

hmcts-jenkins-a-to-c Bot deployed to preview April 1, 2026 11:35 View deployment

Merge branch 'master' into DTSCCI-3856

873de1c

hmcts-jenkins-a-to-c Bot deployed to preview April 2, 2026 14:19 View deployment

hmcts-jenkins-a-to-c Bot deployed to preview April 2, 2026 14:40 View deployment

hmcts-jenkins-a-to-c Bot deployed to preview April 2, 2026 14:56 View deployment

hmcts-jenkins-a-to-c Bot deployed to preview April 7, 2026 07:57 View deployment

hmcts-jenkins-a-to-c Bot deployed to preview April 7, 2026 08:07 View deployment

Merge branch 'master' into DTSCCI-3856

48ecf1a

hmcts-jenkins-a-to-c Bot deployed to preview April 7, 2026 08:53 View deployment

hmcts-jenkins-a-to-c Bot deployed to preview April 7, 2026 10:49 View deployment

douglasrice added prValues: fullDeployment pr-values:fullDeployment and removed prValues: fullDeployment pr-values:fullDeployment labels Apr 7, 2026

github-actions Bot added the stale label Apr 13, 2026

github-actions Bot closed this Apr 13, 2026

matt-goodwin-solirius removed stale aat/destroy prod/destroy labels Apr 14, 2026

matt-goodwin-solirius reopened this Apr 14, 2026

Merge branch 'master' into DTSCCI-3856

e7cc0ec

hmcts-jenkins-a-to-c Bot deployed to preview April 14, 2026 09:22 View deployment

hmcts-jenkins-a-to-c Bot added the rel:civil-service-pr-7678 label Apr 14, 2026

Merge branch 'master' into DTSCCI-3856

d8a13d6

hmcts-jenkins-a-to-c Bot deployed to preview April 16, 2026 14:53 View deployment

Merge branch 'master' into DTSCCI-3856

4674906

hmcts-jenkins-a-to-c Bot deployed to preview April 20, 2026 08:52 View deployment

Merge branch 'master' into DTSCCI-3856

752d6a3

hmcts-jenkins-a-to-c Bot deployed to preview April 20, 2026 10:03 View deployment

Merge branch 'master' into DTSCCI-3856

0b47e85

hmcts-jenkins-a-to-c Bot deployed to preview April 20, 2026 10:58 View deployment

Merge branch 'master' into DTSCCI-3856

f1ae7de

hmcts-jenkins-a-to-c Bot deployed to preview April 20, 2026 13:09 View deployment

matt-goodwin-solirius merged commit 3d59a2b into master Apr 20, 2026
8 checks passed

matt-goodwin-solirius deleted the DTSCCI-3856 branch April 20, 2026 13:46

rakeshchiluka14 pushed a commit that referenced this pull request Apr 21, 2026

DTSCCI-3856 High severity constant naming cleanup in DJ enums (#7678)

46f7511

Co-authored-by: douglasrice <douglasrice@yahoo.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DTSCCI-3856 High severity constant naming cleanup in DJ enums#7678

DTSCCI-3856 High severity constant naming cleanup in DJ enums#7678
matt-goodwin-solirius merged 9 commits intomasterfrom
DTSCCI-3856

matt-goodwin-solirius commented Mar 31, 2026

Uh oh!

hmcts-jenkins-a-to-c Bot commented Apr 1, 2026

Uh oh!

hmcts-jenkins-a-to-c Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matt-goodwin-solirius commented Mar 31, 2026

JIRA link (if applicable)

Change description

Uh oh!

hmcts-jenkins-a-to-c Bot commented Apr 1, 2026

Plan Result (aat)

⚠️ Resource Deletion will happen

Uh oh!

hmcts-jenkins-a-to-c Bot commented Apr 1, 2026

Plan Result (prod)

⚠️ Resource Deletion will happen

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants